Skip to content

linux-cachyos-rc: Add support for Distributed ThinLTO #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

1Naim
Copy link
Member

@1Naim 1Naim commented Apr 22, 2025

Add distributed ThinLTO build support for the Linux kernel. This new mode offers several advantages: (1) Increased flexibility in handling user-specified build options. (2) Improved user-friendliness for developers. (3) Greater convenience for integrating with objtool and livepatch.

Note that "distributed" in this context refers to a term that differentiates in-process ThinLTO builds by invoking backend compilation through the linker, not necessarily building in distributed environments.

Depends on dfd4c69f9f12f8fdd68e08cdba250e37cefc93ce so merge this when 6.15rc4 is released

Link: https://lore.kernel.org/[email protected]/

@1Naim 1Naim marked this pull request as draft April 22, 2025 15:08
@ptr1337
Copy link
Member

ptr1337 commented Apr 22, 2025

I think we should wait till there are a bunch of reviews/acks in upstream before merging this. Otherwise we end again having something in, which will never get pushed, like latency-nice as a good example.

@1Naim
Copy link
Member Author

1Naim commented Apr 23, 2025

I'm okay with that. Do you still want to keep the patch around in base or leave it out as an extra patch for now?

@ptr1337
Copy link
Member

ptr1337 commented Apr 23, 2025

I'm okay with that. Do you still want to keep the patch around in base or leave it out as an extra patch for now?

I think we can keep it for now for testing reasons.

@1Naim
Copy link
Member Author

1Naim commented May 26, 2025

Well since it looks like it's going to be merged, what say we merge this too?

@ptr1337
Copy link
Member

ptr1337 commented May 27, 2025

Yes, can be merged you need to undraft

1Naim and others added 2 commits May 27, 2025 18:20
Add distributed ThinLTO build support for the Linux kernel.
This new mode offers several advantages: (1) Increased
flexibility in handling user-specified build options.
(2) Improved user-friendliness for developers. (3) Greater
convenience for integrating with objtool and livepatch.

Note that "distributed" in this context refers to a term
that differentiates in-process ThinLTO builds by invoking
backend compilation through the linker, not necessarily
building in distributed environments.

Depends on dfd4c69f9f12f8fdd68e08cdba250e37cefc93ce so merge this when
6.15rc4 is released

Link: https://lore.kernel.org/[email protected]/
Signed-off-by: Eric Naim <[email protected]>
@sirlucjan sirlucjan marked this pull request as ready for review May 27, 2025 16:27
@sirlucjan
Copy link
Member

I've rebased PR (I talked with @1Naim about it). thin is still default in linux-cachyos.
@ptr1337 could you take a look?

@sirlucjan sirlucjan requested a review from ptr1337 May 27, 2025 16:29
Copy link
Member

@ptr1337 ptr1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some info what thin-dist improves (debugging and compile time)

@ptr1337 ptr1337 merged commit b5d3bc6 into master May 27, 2025
0 of 2 checks passed
@ptr1337 ptr1337 deleted the feat/rc-thindist branch May 27, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants